Quellcode durchsuchen

Possible null-pointer dereference

The value should be dereferenced after
assertion is performed. This can lead
to crash

(cherry picked from commit 7eba14cb76a131f262c2a760df4bb9402f315a64)
Mikhail Lappo vor 9 Jahren
Ursprung
Commit
dbb3b3a3a1
1 geänderte Dateien mit 2 neuen und 1 gelöschten Zeilen
  1. 2 1
      src/apps/mqtt/mqtt.c

+ 2 - 1
src/apps/mqtt/mqtt.c

@@ -360,8 +360,9 @@ mqtt_take_request(struct mqtt_request_t **tail, u16_t pkt_id)
 static void
 mqtt_request_time_elapsed(struct mqtt_request_t **tail, u8_t t)
 {
-  struct mqtt_request_t *r = *tail;
+  struct mqtt_request_t *r;
   LWIP_ASSERT("mqtt_request_time_elapsed: tail != NULL", tail != NULL);
+  r = *tail;
   while (t > 0 && r != NULL) {
     if (t >= r->timeout_diff) {
       t -= (u8_t)r->timeout_diff;