install valgrind in CI, fix valgrind err in CV

.github/workflows/CI.yml

@@ -23,6 +23,7 @@ jobs:
       run: |
         sudo apt install ninja-build
         sudo apt install liblua5.3-dev
+        sudo apt install valgrind
   
     - name: install_google_benchmark
       run: |

.github/workflows/TEST.yml

@@ -23,6 +23,7 @@ jobs:
       run: |
         sudo apt install ninja-build
         sudo apt install liblua5.3-dev
+        sudo apt install valgrind
   
     - name: install_google_benchmark
       run: git clone --branch v1.6.1 https://github.com/google/benchmark.git && cd benchmark && cmake -E make_directory "build" && cmake -E chdir "build" cmake -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on -DCMAKE_BUILD_TYPE=Release ../ && cmake --build "build" --config Release && sudo cmake --build "build" --config Release --target install

package/PikaCV/PikaCV_Transforms.c

@@ -19,7 +19,7 @@ void PikaCV_Transforms_rotateDown(PikaObj* self, PikaObj* image) {
     int width = img->width;
     int height = img->height;
     int size_new = width * height * 3;
-    Arg* arg_data_new = arg_newBytes(NULL, size_new);
+    Arg* arg_data_new = arg_setBytes(NULL, "", NULL, size_new);
     uint8_t* data = _image_getData(image);
     uint8_t* data_new = arg_getBytes(arg_data_new);
     int i, j, k;
@@ -37,48 +37,47 @@ void PikaCV_Transforms_rotateDown(PikaObj* self, PikaObj* image) {
     arg_deinit(arg_data_new);
 }
 
-void PikaCV_Transforms_threshold(PikaObj *self, PikaObj* image, int maxval, int thre, int thresholdType){
+void PikaCV_Transforms_threshold(PikaObj* self,
+                                 PikaObj* image,
+                                 int maxval,
+                                 int thre,
+                                 int thresholdType) {
     PikaCV_Image* src = obj_getStruct(image, "image");
-    
+
     if (NULL == src) {
         pika_assert(0);
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
 
     uint8_t* src_data = _image_getData(image);
-    
+
     int i;
-    if(thresholdType == 0 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? maxval : 0 ;
+    if (thresholdType == 0) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? maxval : 0;
         }
-    }
-    else if(thresholdType == 1 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? 0 : maxval ;
+    } else if (thresholdType == 1) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? 0 : maxval;
         }
-    }
-    else if(thresholdType == 2 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? thre : src_data[i] ;
+    } else if (thresholdType == 2) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? thre : src_data[i];
         }
-    }
-    else if(thresholdType == 3 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? src_data[i] : 0 ;
+    } else if (thresholdType == 3) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? src_data[i] : 0;
         }
-    }    
-    else if(thresholdType == 4 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? 0 : src_data[i] ;
+    } else if (thresholdType == 4) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? 0 : src_data[i];
         }
-    }
-    else if(thresholdType == 5 ){
-        PikaCV_Transforms_setOTSU(self,image);
-    }else{
+    } else if (thresholdType == 5) {
+        PikaCV_Transforms_setOTSU(self, image);
+    } else {
         pika_assert(0);
         return;
     }
@@ -86,7 +85,12 @@ void PikaCV_Transforms_threshold(PikaObj *self, PikaObj* image, int maxval, int
     obj_setBytes(image, "_data", src_data, src->size);
 }
 
-void PikaCV_Transforms_setROI(PikaObj *self, int h, PikaObj* image, int w, int x, int y){
+void PikaCV_Transforms_setROI(PikaObj* self,
+                              int h,
+                              PikaObj* image,
+                              int w,
+                              int x,
+                              int y) {
     PikaCV_Image* src = obj_getStruct(image, "image");
     int width = src->width;
     int height = src->height;
@@ -96,80 +100,81 @@ void PikaCV_Transforms_setROI(PikaObj *self, int h, PikaObj* image, int w, int x
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_RGB888) {
-        PikaCV_Converter_toRGB888(self,image);
+        PikaCV_Converter_toRGB888(self, image);
     }
-    if( x <= 0 || y <= 0 || w <= 0 || h <= 0){
+    if (x <= 0 || y <= 0 || w <= 0 || h <= 0) {
         pika_assert(0);
         return;
     }
-    if( x + w > width || y + h > height ){
+    if (x + w > width || y + h > height) {
         pika_assert(0);
         return;
     }
 
     int size_new = h * w * 3;
-    Arg* arg_data_new = arg_newBytes(NULL, size_new);
+    Arg* arg_data_new = arg_setBytes(NULL, "", NULL, size_new);
     uint8_t* data = _image_getData(image);
     uint8_t* data_new = arg_getBytes(arg_data_new);
 
-    for(int i = 0 ; i < h ; i++){
-        for(int j = 0 ; j < w ; j++){
-            data_new[i * 3 * w + j * 3] = data[ (i + y - 1 ) * width * 3 + (j + x - 1 ) * 3 ];
-            data_new[i * 3 * w + j * 3 + 1] = data[ (i + y - 1 ) * width * 3 + ( j + x - 1 ) * 3 + 1];
-            data_new[i * 3 * w + j * 3 + 2] = data[ (i + y - 1 ) * width * 3 + ( j + x - 1 ) * 3 + 2];
+    for (int i = 0; i < h; i++) {
+        for (int j = 0; j < w; j++) {
+            data_new[i * 3 * w + j * 3] =
+                data[(i + y - 1) * width * 3 + (j + x - 1) * 3];
+            data_new[i * 3 * w + j * 3 + 1] =
+                data[(i + y - 1) * width * 3 + (j + x - 1) * 3 + 1];
+            data_new[i * 3 * w + j * 3 + 2] =
+                data[(i + y - 1) * width * 3 + (j + x - 1) * 3 + 2];
         }
     }
     src->height = h;
     src->width = w;
     src->size = size_new;
-    
+
     obj_setBytes(image, "_data", data_new, size_new);
     arg_deinit(arg_data_new);
-
 }
 
-int PikaCV_Transforms_getOTSUthre(PikaObj *self, PikaObj* image){
+int PikaCV_Transforms_getOTSUthre(PikaObj* self, PikaObj* image) {
     PikaCV_Image* src = obj_getStruct(image, "image");
-    
+
     if (NULL == src) {
         pika_assert(0);
         return 0;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
-    const int Grayscale=256;
+    const int Grayscale = 256;
     int width = src->width;
     int height = src->height;
     int size = src->size;
     int threshold = 0;
-    int graynum[256] = { 0 };
+    int graynum[256] = {0};
     uint8_t* data = _image_getData(image);
-    for(int i=0 ; i < size ; i++){
+    for (int i = 0; i < size; i++) {
         graynum[data[i]]++;
     }
 
-    double P[256] = { 0.0 };   
-    double PK[256] = { 0.0 };
-    double MK[256] = { 0.0 };
-    double srcpixnum = width*height, sumtmpPK = 0, sumtmpMK = 0;
-    for (int i = 0; i < Grayscale; ++i){
+    double P[256] = {0.0};
+    double PK[256] = {0.0};
+    double MK[256] = {0.0};
+    double srcpixnum = width * height, sumtmpPK = 0, sumtmpMK = 0;
+    for (int i = 0; i < Grayscale; ++i) {
         P[i] = graynum[i] / srcpixnum;
-        PK[i] = sumtmpPK + P[i]; 
+        PK[i] = sumtmpPK + P[i];
         sumtmpPK = PK[i];
-        MK[i] = sumtmpMK + i*P[i];                                                                                                                                                                                                                                                                                                                                                                                                          
+        MK[i] = sumtmpMK + i * P[i];
         sumtmpMK = MK[i];
     }
 
-    double Var=0;
-    for (int k = 0; k < Grayscale; ++k){
-        if(PK[k] > 0.0)
-        {
-            double t = MK[Grayscale-1] * PK[k] - MK[k];
+    double Var = 0;
+    for (int k = 0; k < Grayscale; ++k) {
+        if (PK[k] > 0.0) {
+            double t = MK[Grayscale - 1] * PK[k] - MK[k];
             double w = PK[k] * (1 - PK[k]);
-            double variance = t * t / w ;
-            if (variance > Var){
-                Var = variance ;
+            double variance = t * t / w;
+            if (variance > Var) {
+                Var = variance;
                 threshold = k;
             }
         }
@@ -178,7 +183,7 @@ int PikaCV_Transforms_getOTSUthre(PikaObj *self, PikaObj* image){
     return threshold;
 }
 
-void PikaCV_Transforms_setOTSU(PikaObj *self, PikaObj* image){
+void PikaCV_Transforms_setOTSU(PikaObj* self, PikaObj* image) {
     PikaCV_Image* src = obj_getStruct(image, "image");
 
     if (NULL == src) {
@@ -186,15 +191,15 @@ void PikaCV_Transforms_setOTSU(PikaObj *self, PikaObj* image){
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
 
-    int thre = PikaCV_Transforms_getOTSUthre(self,image);
+    int thre = PikaCV_Transforms_getOTSUthre(self, image);
     uint8_t* src_data = _image_getData(image);
-    
+
     int i;
-    for (i = 0; i < (src->size) ; i++) {
-        src_data[i] = src_data[i] > thre ? 255 : 0 ;
+    for (i = 0; i < (src->size); i++) {
+        src_data[i] = src_data[i] > thre ? 255 : 0;
     }
 
     obj_setBytes(image, "_data", src_data, src->size);
@@ -203,7 +208,11 @@ void PikaCV_Transforms_setOTSU(PikaObj *self, PikaObj* image){
 #define MAX(a, b) ((a) > (b) ? (a) : (b))
 #define MIN(a, b) ((a) < (b) ? (a) : (b))
 
-void PikaCV_Transforms_resize(PikaObj *self, PikaObj* image, int resizeType, int x, int y){
+void PikaCV_Transforms_resize(PikaObj* self,
+                              PikaObj* image,
+                              int resizeType,
+                              int x,
+                              int y) {
     PikaCV_Image* src = obj_getStruct(image, "image");
     int width = src->width;
     int height = src->height;
@@ -211,89 +220,99 @@ void PikaCV_Transforms_resize(PikaObj *self, PikaObj* image, int resizeType, int
         pika_assert(0);
         return;
     }
-    if( x <= 0 || y <= 0 ){
+    if (x <= 0 || y <= 0) {
         pika_assert(0);
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_RGB888) {
-        PikaCV_Converter_toRGB888(self,image);
-    }    
+        PikaCV_Converter_toRGB888(self, image);
+    }
 
     int size_new = x * y * 3;
-    Arg* arg_data_new = arg_newBytes(NULL, size_new);
+    Arg* arg_data_new = arg_setBytes(NULL, "", NULL, size_new);
     uint8_t* data = _image_getData(image);
     uint8_t* data_new = arg_getBytes(arg_data_new);
 
-    double scale_x = (double)width / (double)x;  
-    double scale_y = (double)height / (double)y;   
-    if(resizeType == 0){
-        for (int i = 0; i < y ; ++i)  
-        {  
-            int sy = floor(i * scale_y);  
-            sy = MIN(sy , ( height - 1 ));
-            for (int j = 0; j < x ; ++j)  
-            {  
-                int sx = floor(j * scale_x);  
-                sx = MIN(sx , ( width - 1 ));
-
-                data_new[i * x * 3 + j * 3]=data[sy * width * 3 + sx * 3];
-                data_new[i * x * 3 + j * 3 + 1]=data[sy * width * 3 + sx * 3 + 1];
-                data_new[i * x * 3 + j * 3 + 2]=data[sy * width * 3 + sx * 3 + 2];
-            }  
-        }  
-    }else{
+    double scale_x = (double)width / (double)x;
+    double scale_y = (double)height / (double)y;
+    if (resizeType == 0) {
+        for (int i = 0; i < y; ++i) {
+            int sy = floor(i * scale_y);
+            sy = MIN(sy, (height - 1));
+            for (int j = 0; j < x; ++j) {
+                int sx = floor(j * scale_x);
+                sx = MIN(sx, (width - 1));
+
+                data_new[i * x * 3 + j * 3] = data[sy * width * 3 + sx * 3];
+                data_new[i * x * 3 + j * 3 + 1] =
+                    data[sy * width * 3 + sx * 3 + 1];
+                data_new[i * x * 3 + j * 3 + 2] =
+                    data[sy * width * 3 + sx * 3 + 2];
+            }
+        }
+    } else {
         pika_assert(0);
         return;
     }
     src->height = y;
     src->width = x;
     src->size = size_new;
-    
+
     obj_setBytes(image, "_data", data_new, size_new);
     arg_deinit(arg_data_new);
 }
 
-#undef MAX
-#undef MIN
-
-void PikaCV_Transforms_adaptiveThreshold(PikaObj *self, int c, PikaObj* image, int maxval, int method, int subsize){
+void PikaCV_Transforms_adaptiveThreshold(PikaObj* self,
+                                         int c,
+                                         PikaObj* image,
+                                         int maxval,
+                                         int method,
+                                         int subsize) {
     PikaCV_Image* src = obj_getStruct(image, "image");
 
     if (NULL == src) {
         pika_assert(0);
         return;
     }
-    if(c<-255||c>255){
+    if (c < 0 || c > 255) {
         pika_assert(0);
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
 
     int size = src->size;
     uint8_t* src_data = _image_getData(image);
-    
-    switch (method)
-	{
-	case 0:
-		PikaCV_Filter_meanFilter(self,image,subsize,subsize);  //均值滤波
-		break;
-	case 1:
-		PikaCV_Filter_medianFilter(self,image);   //中值滤波
-		break;
-	default:
-		break;
-	}
+    uint8_t* src_copy;
+    src_copy = (uint8_t*)calloc(size, 1);
+
+    memcpy(src_copy, src_data, size);
 
+    if (method == 0) {
+        PikaCV_Filter_meanFilter(self, image, subsize, subsize);  //均值滤波
+    } else if (method == 1) {
+        PikaCV_Filter_medianFilter(self, image);  //中值滤波
+    } else {
+        free(src_copy);
+        return;
+    }
+ 
+    /* update size after filter */
+    size = src->size;
     uint8_t* smooth_data = _image_getData(image);
-    for(int i=0;i<size;i++){
-        smooth_data[i] -= c;
+    for (int i = 0; i < size; i++) {
+        uint8_t result = smooth_data[i] - (uint8_t)c;
+        smooth_data[i] =
+            ((result < MIN(smooth_data[i], (uint8_t)c)) ? 0 : result);
     }
-    for(int i=0;i<size;i++){
-        src_data[i] = src_data[i] > smooth_data[i] ? maxval : 0 ;
+    for (int i = 0; i < size; i++) {
+        src_copy[i] = ((src_copy[i] > smooth_data[i]) ? (uint8_t)maxval : 0);
     }
 
-    obj_setBytes(image, "_data", src_data, src->size);
-
+    obj_setBytes(image, "_data", src_copy, size);
+    free(src_copy);
 }
+
+#undef MAX
+#undef MIN

port/linux/package/pikascript/pikascript-lib/PikaCV/PikaCV_Transforms.c

@@ -37,48 +37,47 @@ void PikaCV_Transforms_rotateDown(PikaObj* self, PikaObj* image) {
     arg_deinit(arg_data_new);
 }
 
-void PikaCV_Transforms_threshold(PikaObj *self, PikaObj* image, int maxval, int thre, int thresholdType){
+void PikaCV_Transforms_threshold(PikaObj* self,
+                                 PikaObj* image,
+                                 int maxval,
+                                 int thre,
+                                 int thresholdType) {
     PikaCV_Image* src = obj_getStruct(image, "image");
-    
+
     if (NULL == src) {
         pika_assert(0);
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
 
     uint8_t* src_data = _image_getData(image);
-    
+
     int i;
-    if(thresholdType == 0 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? maxval : 0 ;
+    if (thresholdType == 0) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? maxval : 0;
         }
-    }
-    else if(thresholdType == 1 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? 0 : maxval ;
+    } else if (thresholdType == 1) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? 0 : maxval;
         }
-    }
-    else if(thresholdType == 2 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? thre : src_data[i] ;
+    } else if (thresholdType == 2) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? thre : src_data[i];
         }
-    }
-    else if(thresholdType == 3 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? src_data[i] : 0 ;
+    } else if (thresholdType == 3) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? src_data[i] : 0;
         }
-    }    
-    else if(thresholdType == 4 ){
-        for (i = 0; i < (src->size) ; i++) {
-            src_data[i] = src_data[i] > thre ? 0 : src_data[i] ;
+    } else if (thresholdType == 4) {
+        for (i = 0; i < (src->size); i++) {
+            src_data[i] = src_data[i] > thre ? 0 : src_data[i];
         }
-    }
-    else if(thresholdType == 5 ){
-        PikaCV_Transforms_setOTSU(self,image);
-    }else{
+    } else if (thresholdType == 5) {
+        PikaCV_Transforms_setOTSU(self, image);
+    } else {
         pika_assert(0);
         return;
     }
@@ -86,7 +85,12 @@ void PikaCV_Transforms_threshold(PikaObj *self, PikaObj* image, int maxval, int
     obj_setBytes(image, "_data", src_data, src->size);
 }
 
-void PikaCV_Transforms_setROI(PikaObj *self, int h, PikaObj* image, int w, int x, int y){
+void PikaCV_Transforms_setROI(PikaObj* self,
+                              int h,
+                              PikaObj* image,
+                              int w,
+                              int x,
+                              int y) {
     PikaCV_Image* src = obj_getStruct(image, "image");
     int width = src->width;
     int height = src->height;
@@ -96,13 +100,13 @@ void PikaCV_Transforms_setROI(PikaObj *self, int h, PikaObj* image, int w, int x
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_RGB888) {
-        PikaCV_Converter_toRGB888(self,image);
+        PikaCV_Converter_toRGB888(self, image);
     }
-    if( x <= 0 || y <= 0 || w <= 0 || h <= 0){
+    if (x <= 0 || y <= 0 || w <= 0 || h <= 0) {
         pika_assert(0);
         return;
     }
-    if( x + w > width || y + h > height ){
+    if (x + w > width || y + h > height) {
         pika_assert(0);
         return;
     }
@@ -112,64 +116,65 @@ void PikaCV_Transforms_setROI(PikaObj *self, int h, PikaObj* image, int w, int x
     uint8_t* data = _image_getData(image);
     uint8_t* data_new = arg_getBytes(arg_data_new);
 
-    for(int i = 0 ; i < h ; i++){
-        for(int j = 0 ; j < w ; j++){
-            data_new[i * 3 * w + j * 3] = data[ (i + y - 1 ) * width * 3 + (j + x - 1 ) * 3 ];
-            data_new[i * 3 * w + j * 3 + 1] = data[ (i + y - 1 ) * width * 3 + ( j + x - 1 ) * 3 + 1];
-            data_new[i * 3 * w + j * 3 + 2] = data[ (i + y - 1 ) * width * 3 + ( j + x - 1 ) * 3 + 2];
+    for (int i = 0; i < h; i++) {
+        for (int j = 0; j < w; j++) {
+            data_new[i * 3 * w + j * 3] =
+                data[(i + y - 1) * width * 3 + (j + x - 1) * 3];
+            data_new[i * 3 * w + j * 3 + 1] =
+                data[(i + y - 1) * width * 3 + (j + x - 1) * 3 + 1];
+            data_new[i * 3 * w + j * 3 + 2] =
+                data[(i + y - 1) * width * 3 + (j + x - 1) * 3 + 2];
         }
     }
     src->height = h;
     src->width = w;
     src->size = size_new;
-    
+
     obj_setBytes(image, "_data", data_new, size_new);
     arg_deinit(arg_data_new);
-
 }
 
-int PikaCV_Transforms_getOTSUthre(PikaObj *self, PikaObj* image){
+int PikaCV_Transforms_getOTSUthre(PikaObj* self, PikaObj* image) {
     PikaCV_Image* src = obj_getStruct(image, "image");
-    
+
     if (NULL == src) {
         pika_assert(0);
         return 0;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
-    const int Grayscale=256;
+    const int Grayscale = 256;
     int width = src->width;
     int height = src->height;
     int size = src->size;
     int threshold = 0;
-    int graynum[256] = { 0 };
+    int graynum[256] = {0};
     uint8_t* data = _image_getData(image);
-    for(int i=0 ; i < size ; i++){
+    for (int i = 0; i < size; i++) {
         graynum[data[i]]++;
     }
 
-    double P[256] = { 0.0 };   
-    double PK[256] = { 0.0 };
-    double MK[256] = { 0.0 };
-    double srcpixnum = width*height, sumtmpPK = 0, sumtmpMK = 0;
-    for (int i = 0; i < Grayscale; ++i){
+    double P[256] = {0.0};
+    double PK[256] = {0.0};
+    double MK[256] = {0.0};
+    double srcpixnum = width * height, sumtmpPK = 0, sumtmpMK = 0;
+    for (int i = 0; i < Grayscale; ++i) {
         P[i] = graynum[i] / srcpixnum;
-        PK[i] = sumtmpPK + P[i]; 
+        PK[i] = sumtmpPK + P[i];
         sumtmpPK = PK[i];
-        MK[i] = sumtmpMK + i*P[i];                                                                                                                                                                                                                                                                                                                                                                                                          
+        MK[i] = sumtmpMK + i * P[i];
         sumtmpMK = MK[i];
     }
 
-    double Var=0;
-    for (int k = 0; k < Grayscale; ++k){
-        if(PK[k] > 0.0)
-        {
-            double t = MK[Grayscale-1] * PK[k] - MK[k];
+    double Var = 0;
+    for (int k = 0; k < Grayscale; ++k) {
+        if (PK[k] > 0.0) {
+            double t = MK[Grayscale - 1] * PK[k] - MK[k];
             double w = PK[k] * (1 - PK[k]);
-            double variance = t * t / w ;
-            if (variance > Var){
-                Var = variance ;
+            double variance = t * t / w;
+            if (variance > Var) {
+                Var = variance;
                 threshold = k;
             }
         }
@@ -178,7 +183,7 @@ int PikaCV_Transforms_getOTSUthre(PikaObj *self, PikaObj* image){
     return threshold;
 }
 
-void PikaCV_Transforms_setOTSU(PikaObj *self, PikaObj* image){
+void PikaCV_Transforms_setOTSU(PikaObj* self, PikaObj* image) {
     PikaCV_Image* src = obj_getStruct(image, "image");
 
     if (NULL == src) {
@@ -186,15 +191,15 @@ void PikaCV_Transforms_setOTSU(PikaObj *self, PikaObj* image){
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
 
-    int thre = PikaCV_Transforms_getOTSUthre(self,image);
+    int thre = PikaCV_Transforms_getOTSUthre(self, image);
     uint8_t* src_data = _image_getData(image);
-    
+
     int i;
-    for (i = 0; i < (src->size) ; i++) {
-        src_data[i] = src_data[i] > thre ? 255 : 0 ;
+    for (i = 0; i < (src->size); i++) {
+        src_data[i] = src_data[i] > thre ? 255 : 0;
     }
 
     obj_setBytes(image, "_data", src_data, src->size);
@@ -203,7 +208,11 @@ void PikaCV_Transforms_setOTSU(PikaObj *self, PikaObj* image){
 #define MAX(a, b) ((a) > (b) ? (a) : (b))
 #define MIN(a, b) ((a) < (b) ? (a) : (b))
 
-void PikaCV_Transforms_resize(PikaObj *self, PikaObj* image, int resizeType, int x, int y){
+void PikaCV_Transforms_resize(PikaObj* self,
+                              PikaObj* image,
+                              int resizeType,
+                              int x,
+                              int y) {
     PikaCV_Image* src = obj_getStruct(image, "image");
     int width = src->width;
     int height = src->height;
@@ -211,92 +220,94 @@ void PikaCV_Transforms_resize(PikaObj *self, PikaObj* image, int resizeType, int
         pika_assert(0);
         return;
     }
-    if( x <= 0 || y <= 0 ){
+    if (x <= 0 || y <= 0) {
         pika_assert(0);
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_RGB888) {
-        PikaCV_Converter_toRGB888(self,image);
-    }    
+        PikaCV_Converter_toRGB888(self, image);
+    }
 
     int size_new = x * y * 3;
     Arg* arg_data_new = arg_setBytes(NULL, "", NULL, size_new);
     uint8_t* data = _image_getData(image);
     uint8_t* data_new = arg_getBytes(arg_data_new);
 
-    double scale_x = (double)width / (double)x;  
-    double scale_y = (double)height / (double)y;   
-    if(resizeType == 0){
-        for (int i = 0; i < y ; ++i)  
-        {  
-            int sy = floor(i * scale_y);  
-            sy = MIN(sy , ( height - 1 ));
-            for (int j = 0; j < x ; ++j)  
-            {  
-                int sx = floor(j * scale_x);  
-                sx = MIN(sx , ( width - 1 ));
-
-                data_new[i * x * 3 + j * 3]=data[sy * width * 3 + sx * 3];
-                data_new[i * x * 3 + j * 3 + 1]=data[sy * width * 3 + sx * 3 + 1];
-                data_new[i * x * 3 + j * 3 + 2]=data[sy * width * 3 + sx * 3 + 2];
-            }  
-        }  
-    }else{
+    double scale_x = (double)width / (double)x;
+    double scale_y = (double)height / (double)y;
+    if (resizeType == 0) {
+        for (int i = 0; i < y; ++i) {
+            int sy = floor(i * scale_y);
+            sy = MIN(sy, (height - 1));
+            for (int j = 0; j < x; ++j) {
+                int sx = floor(j * scale_x);
+                sx = MIN(sx, (width - 1));
+
+                data_new[i * x * 3 + j * 3] = data[sy * width * 3 + sx * 3];
+                data_new[i * x * 3 + j * 3 + 1] =
+                    data[sy * width * 3 + sx * 3 + 1];
+                data_new[i * x * 3 + j * 3 + 2] =
+                    data[sy * width * 3 + sx * 3 + 2];
+            }
+        }
+    } else {
         pika_assert(0);
         return;
     }
     src->height = y;
     src->width = x;
     src->size = size_new;
-    
+
     obj_setBytes(image, "_data", data_new, size_new);
     arg_deinit(arg_data_new);
 }
 
-
-
-void PikaCV_Transforms_adaptiveThreshold(PikaObj *self, int c, PikaObj* image, int maxval, int method, int subsize){
+void PikaCV_Transforms_adaptiveThreshold(PikaObj* self,
+                                         int c,
+                                         PikaObj* image,
+                                         int maxval,
+                                         int method,
+                                         int subsize) {
     PikaCV_Image* src = obj_getStruct(image, "image");
 
     if (NULL == src) {
         pika_assert(0);
         return;
     }
-    if(c < 0 || c > 255){
+    if (c < 0 || c > 255) {
         pika_assert(0);
         return;
     }
     if (src->format != PikaCV_ImageFormat_Type_GRAY) {
-        PikaCV_Converter_toGray(self,image);
+        PikaCV_Converter_toGray(self, image);
     }
 
     int size = src->size;
     uint8_t* src_data = _image_getData(image);
-    uint8_t* src_copy ;
-    src_copy = (uint8_t *)calloc(size,1);
-
-    memcpy(src_copy,src_data,size);
-
-    if (method==0)
-	{
-		PikaCV_Filter_meanFilter(self,image,subsize,subsize);  //均值滤波
-	}
-	else if(method == 1){
-		PikaCV_Filter_medianFilter(self,image);   //中值滤波
-	}
-	else{
+    uint8_t* src_copy;
+    src_copy = (uint8_t*)calloc(size, 1);
+
+    memcpy(src_copy, src_data, size);
+
+    if (method == 0) {
+        PikaCV_Filter_meanFilter(self, image, subsize, subsize);  //均值滤波
+    } else if (method == 1) {
+        PikaCV_Filter_medianFilter(self, image);  //中值滤波
+    } else {
         free(src_copy);
         return;
-	}
-
+    }
+ 
+    /* update size after filter */
+    size = src->size;
     uint8_t* smooth_data = _image_getData(image);
-    for(int i=0;i<size;i++){
-        
+    for (int i = 0; i < size; i++) {
         uint8_t result = smooth_data[i] - (uint8_t)c;
-        smooth_data[i] = ((result < MIN(smooth_data[i], (uint8_t)c)) ? 0 : result);
+        smooth_data[i] =
+            ((result < MIN(smooth_data[i], (uint8_t)c)) ? 0 : result);
     }
-    for(int i=0;i<size;i++){
-        src_copy[i] = ((src_copy[i] > smooth_data[i]) ? (uint8_t)maxval : 0) ;
+    for (int i = 0; i < size; i++) {
+        src_copy[i] = ((src_copy[i] > smooth_data[i]) ? (uint8_t)maxval : 0);
     }
 
     obj_setBytes(image, "_data", src_copy, size);

port/linux/test/PikaCV-test.cpp

@@ -136,7 +136,7 @@ TEST(PikaCV, test9) {
 }
 
 //! test faild in valgrind.sh, need fix.
-#if 0
+#if 1
 TEST(PikaCV, test10) {
     /* init */
     pikaMemInfo.heapUsedMax = 0;