Przeglądaj źródła

Merge pull request #299 from EIPStackGroup/SonarCloud_Issue_EthernetLink

SonarCloud issue
Martin Melik-Merkumians 5 lat temu
rodzic
commit
8f2aece28f
1 zmienionych plików z 3 dodań i 2 usunięć
  1. 3 2
      source/src/cip/cipethernetlink.c

+ 3 - 2
source/src/cip/cipethernetlink.c

@@ -432,9 +432,10 @@ static void EncodeCipEthernetLinkInterfaceCaps(const void *const data,
   const CipEthernetLinkMetaInterfaceCapability *const interface_caps = data;
   const CipEthernetLinkMetaInterfaceCapability *const interface_caps = data;
   EncodeCipDword(&interface_caps->capability_bits, outgoing_message);
   EncodeCipDword(&interface_caps->capability_bits, outgoing_message);
   uint16_t selected = interface_caps->speed_duplex_selector;
   uint16_t selected = interface_caps->speed_duplex_selector;
-  CipUsint count;
-  for (count = 0; selected; count++) { /* count # of bits set */
+  CipUsint count = 0;
+  while(selected) { /* count # of bits set */
     selected &= selected - 1U;        /* clear the least significant bit set */
     selected &= selected - 1U;        /* clear the least significant bit set */
+    count++;
   }
   }
   EncodeCipUsint(&count, outgoing_message);
   EncodeCipUsint(&count, outgoing_message);