Răsfoiți Sursa

Merge branch 'ci/fix_dangerjs_close_not_jira_link' into 'master'

ci: fix dangerjs "closes anything_but_not_a_jira_link"

See merge request espressif/esp-idf!22797
Fu Hanxi 2 ani în urmă
părinte
comite
ca5dd7f0b3
1 a modificat fișierele cu 15 adăugiri și 12 ștergeri
  1. 15 12
      .gitlab/dangerjs/mrDescriptionJiraLinks.js

+ 15 - 12
.gitlab/dangerjs/mrDescriptionJiraLinks.js

@@ -139,18 +139,21 @@ module.exports = async function () {
             const correctJiraClosingLinkFormat = new RegExp(
             const correctJiraClosingLinkFormat = new RegExp(
                 `^- Closes ${jiraTicketRegex.source}$`
                 `^- Closes ${jiraTicketRegex.source}$`
             );
             );
-            if (!correctJiraClosingLinkFormat.test(line)) {
-                closingTickets.push({
-                    record: line,
-                    ticketName: line.match(jiraTicketRegex)[0],
-                    correctFormat: false,
-                });
-            } else {
-                closingTickets.push({
-                    record: line,
-                    ticketName: line.match(jiraTicketRegex)[0],
-                    correctFormat: true,
-                });
+            const matchedJiraTicket = line.match(jiraTicketRegex);
+            if (matchedJiraTicket) {
+                if (!correctJiraClosingLinkFormat.test(line)) {
+                    closingTickets.push({
+                        record: line,
+                        ticketName: matchedJiraTicket[0],
+                        correctFormat: false,
+                    });
+                } else {
+                    closingTickets.push({
+                        record: line,
+                        ticketName: matchedJiraTicket[0],
+                        correctFormat: true,
+                    });
+                }
             }
             }
         }
         }
         return closingTickets;
         return closingTickets;