Преглед изворни кода

Merge branch 'bugfix/http_client_test_memcorupt' into 'master'

ci/test: Fix esp_http_client test not to use pointer after free

Closes IDFCI-350

See merge request espressif/esp-idf!11829
David Čermák пре 5 година
родитељ
комит
e1d9abafa8
1 измењених фајлова са 4 додато и 1 уклоњено
  1. 4 1
      components/esp_http_client/test/test_http_client.c

+ 4 - 1
components/esp_http_client/test/test_http_client.c

@@ -124,7 +124,10 @@ TEST_CASE("Username and password will not reset if new absolute URL doesnot spec
     TEST_ASSERT_EQUAL_STRING(USERNAME, value);
     esp_http_client_set_url(client, "http://" HOST "/get");
     esp_http_client_set_username(client, value);
-    esp_http_client_set_password(client, value);
+    // esp_http_client_set_username sets new username and thus invalidates the original one
+    // which we still reference in the local variable `value` (better forget it)
+    value = NULL;
+    esp_http_client_set_password(client, USERNAME);
     //checks if username is set or not
     r = esp_http_client_get_username(client, &value);
     TEST_ASSERT_EQUAL(ESP_OK, r);