hathach 5 лет назад
Родитель
Сommit
3b83813f01

+ 8 - 5
.github/ISSUE_TEMPLATE/bug_report.md

@@ -7,17 +7,20 @@ assignees: ''
 
 
 ---
 ---
 
 
-**Set up (mandatory):**
-Provide details of your setup help us to reproduce the issue as quick as possible  
+**Set up**
+[Mandatory] Provide details of your setup help us to reproduce the issue as quick as possible  
  - **PC OS**   : Ubuntu 18.04 / Windows 10/ macOS 10.15 
  - **PC OS**   : Ubuntu 18.04 / Windows 10/ macOS 10.15 
  - **Board**   : Feather nRF52840 Express
  - **Board**   : Feather nRF52840 Express
  - **Firmware**: examples/device/cdc_msc
  - **Firmware**: examples/device/cdc_msc
 
 
-**Bug Description**
-Describe what the bug is.
+**Describe the bug**
+A clear and concise description of what the bug is.
 
 
-**Reproduce**
+**To reproduce**
 Steps to reproduce the behavior:
 Steps to reproduce the behavior:
 1. Go to '...'
 1. Go to '...'
 2. Click on '....'
 2. Click on '....'
 3. See error
 3. See error
+
+**Log & screenshots**
+If applicable, add screenshots and TinyUSB's log to help explain your problem. To enable logging, add `LOG=2` to your make command if building with stock examples or set `CFG_TUSB_DEBUG=2` in your tusb_config.h.  

+ 5 - 2
.github/ISSUE_TEMPLATE/feature_request.md

@@ -7,5 +7,8 @@ assignees: ''
 
 
 ---
 ---
 
 
-**Feature Description**
-Describe your feature
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.

+ 1 - 1
.github/ISSUE_TEMPLATE/question.md

@@ -7,4 +7,4 @@ assignees: ''
 
 
 ---
 ---
 
 
-**Question Description**
+**Describe what the question is**

+ 0 - 4
README.md

@@ -73,10 +73,6 @@ TinyUSB is completely thread-safe by pushing all ISR events into a central queue
 - **FreeRTOS**
 - **FreeRTOS**
 - **Mynewt** Due to the newt package build system, Mynewt examples are better to be on its [own repo](https://github.com/hathach/mynewt-tinyusb-example) 
 - **Mynewt** Due to the newt package build system, Mynewt examples are better to be on its [own repo](https://github.com/hathach/mynewt-tinyusb-example) 
 
 
-## Compiler & IDE
-
-The stack is developed with GCC compiler and should be compilable with others. The `examples` folder provides Makefile and Segger Embedded Studio build support. [Here are example build instructions](examples/readme.md).
-
 ## Getting Started
 ## Getting Started
 
 
 [Here are the details for getting started](docs/getting_started.md) with the stack.
 [Here are the details for getting started](docs/getting_started.md) with the stack.

+ 3 - 2
src/class/midi/midi_device.c

@@ -88,13 +88,14 @@ bool tud_midi_n_mounted (uint8_t itf)
 static void _prep_out_transaction (midid_interface_t* p_midi)
 static void _prep_out_transaction (midid_interface_t* p_midi)
 {
 {
   // skip if previous transfer not complete
   // skip if previous transfer not complete
-  if ( usbd_edpt_busy(TUD_OPT_RHPORT, p_midi->ep_out) )
-    return;
+  if ( usbd_edpt_busy(TUD_OPT_RHPORT, p_midi->ep_out) ) return;
 
 
   // Prepare for incoming data but only allow what we can store in the ring buffer.
   // Prepare for incoming data but only allow what we can store in the ring buffer.
   uint16_t max_read = tu_fifo_remaining(&p_midi->rx_ff);
   uint16_t max_read = tu_fifo_remaining(&p_midi->rx_ff);
   if ( max_read >= CFG_TUD_MIDI_EPSIZE )
   if ( max_read >= CFG_TUD_MIDI_EPSIZE )
+  {
     usbd_edpt_xfer(TUD_OPT_RHPORT, p_midi->ep_out, p_midi->epout_buf, CFG_TUD_MIDI_EPSIZE);
     usbd_edpt_xfer(TUD_OPT_RHPORT, p_midi->ep_out, p_midi->epout_buf, CFG_TUD_MIDI_EPSIZE);
+  }
 }
 }
 
 
 //--------------------------------------------------------------------+
 //--------------------------------------------------------------------+