فهرست منبع

Address review comments:

- every switch must have a default
- revert formatting of unchanged lines
Ivo Popov 5 سال پیش
والد
کامیت
5178e2af55
1فایلهای تغییر یافته به همراه11 افزوده شده و 4 حذف شده
  1. 11 4
      examples/device/webusb_serial/src/main.c

+ 11 - 4
examples/device/webusb_serial/src/main.c

@@ -152,22 +152,28 @@ bool tud_vendor_control_xfer_cb(uint8_t rhport, uint8_t stage, tusb_control_requ
   if (stage != CONTROL_STAGE_SETUP ) return true;
   if (stage != CONTROL_STAGE_SETUP ) return true;
 
 
   if (request->bmRequestType_bit.type == TUSB_REQ_TYPE_VENDOR) {
   if (request->bmRequestType_bit.type == TUSB_REQ_TYPE_VENDOR) {
-    switch (request->bRequest) {
+    switch (request->bRequest)
+    {
       case VENDOR_REQUEST_WEBUSB:
       case VENDOR_REQUEST_WEBUSB:
         // match vendor request in BOS descriptor
         // match vendor request in BOS descriptor
         // Get landing page url
         // Get landing page url
         return tud_control_xfer(rhport, request, (void*) &desc_url, desc_url.bLength);
         return tud_control_xfer(rhport, request, (void*) &desc_url, desc_url.bLength);
 
 
       case VENDOR_REQUEST_MICROSOFT:
       case VENDOR_REQUEST_MICROSOFT:
-        if ( request->wIndex == 7 ) {
+        if ( request->wIndex == 7 )
+        {
           // Get Microsoft OS 2.0 compatible descriptor
           // Get Microsoft OS 2.0 compatible descriptor
           uint16_t total_len;
           uint16_t total_len;
           memcpy(&total_len, desc_ms_os_20+8, 2);
           memcpy(&total_len, desc_ms_os_20+8, 2);
 
 
           return tud_control_xfer(rhport, request, (void*) desc_ms_os_20, total_len);
           return tud_control_xfer(rhport, request, (void*) desc_ms_os_20, total_len);
-        } else {
+        }else
+        {
           return false;
           return false;
         }
         }
+
+      default:
+        return false;
     }
     }
   } else if (
   } else if (
         request->bmRequestType_bit.type == TUSB_REQ_TYPE_CLASS &&
         request->bmRequestType_bit.type == TUSB_REQ_TYPE_CLASS &&
@@ -182,7 +188,8 @@ bool tud_vendor_control_xfer_cb(uint8_t rhport, uint8_t stage, tusb_control_requ
       blink_interval_ms = BLINK_ALWAYS_ON;
       blink_interval_ms = BLINK_ALWAYS_ON;
 
 
       tud_vendor_write_str("\r\nTinyUSB WebUSB device example\r\n");
       tud_vendor_write_str("\r\nTinyUSB WebUSB device example\r\n");
-    } else {
+    }else
+    {
       blink_interval_ms = BLINK_MOUNTED;
       blink_interval_ms = BLINK_MOUNTED;
     }
     }