Просмотр исходного кода

utest: remove RT_UTEST_USING_ALL_CASES

Many modules' utests currently don't support enabling all
tests at once. Furthermore, some modules' tests are complex,
for example due to their numerous dependencies on other
modules. This makes it nearly impossible to enable all
tests with a single global switch. Consequently, the
previously defined `RT_UTEST_USING_ALL_CASES` has lost
its original meaning.

We recommend deprecating this configuration switch. If a
module needs to enable a group of functional tests through
its own configuration, this local enable all switch should
be implemented by the module itself, and a global RTT enable
switch will no longer be provided.

If such a requirement arises in the future, we recommend
careful design, especially considering how to ensure that
turning on a single switch enables all dependencies for
all involved modules for ease of use.

Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
Chen Wang 3 месяцев назад
Родитель
Сommit
495c8cfc25

+ 1 - 1
bsp/k230/drivers/utest/SConscript

@@ -2,7 +2,7 @@ from building import *
 
 src = []
 
-if GetDepend('RT_UTEST_USING_ALL_CASES') or GetDepend('BSP_UTEST_DRIVERS'):
+if GetDepend('BSP_UTEST_DRIVERS'):
     src += ['test_gpio.c']
     src += ['test_gpio_irq.c']
 

+ 1 - 1
components/drivers/audio/utest/SConscript

@@ -5,7 +5,7 @@ cwd     = GetCurrentDir()
 src     = []
 CPPPATH = [cwd]
 
-if GetDepend('RT_UTEST_USING_ALL_CASES') or GetDepend('RT_UTEST_USING_AUDIO_DRIVER'):
+if GetDepend('RT_UTEST_USING_AUDIO_DRIVER'):
     src += Glob('tc_*.c')
 
 group = DefineGroup('utestcases', src, depend = ['RT_USING_UTESTCASES', 'RT_USING_AUDIO'], CPPPATH = CPPPATH)

+ 1 - 1
components/net/utest/SConscript

@@ -5,7 +5,7 @@ cwd     = GetCurrentDir()
 src     = []
 CPPPATH = [cwd]
 
-if GetDepend('RT_UTEST_USING_ALL_CASES') or GetDepend('RT_UTEST_TC_USING_LWIP') or GetDepend('RT_UTEST_TC_USING_NETDEV'):
+if GetDepend('RT_UTEST_TC_USING_LWIP') or GetDepend('RT_UTEST_TC_USING_NETDEV'):
 
     if GetDepend('RT_UTEST_TC_USING_LWIP'):
         # Add lwIP test source if enabled

+ 0 - 7
components/utilities/Kconfig

@@ -216,13 +216,6 @@ config RT_USING_UTEST
             default n
             help
                 If enable this option, the test cases will be run automatically when board boot up.
-
-        config RT_UTEST_USING_ALL_CASES
-            bool "Enable all selected modules' test cases"
-            default n
-            help
-                If enable this option, all selected modules' test cases will be run.
-                Otherwise, only the test cases that are explicitly enabled will be run.
     endif
 
 config RT_USING_VAR_EXPORT

+ 1 - 1
components/utilities/utest/utest/SConscript

@@ -2,7 +2,7 @@ from building import *
 
 src = []
 
-if GetDepend('RT_UTEST_USING_ALL_CASES') or GetDepend('UTEST_SELF_PASS_TC'):
+if GetDepend('UTEST_SELF_PASS_TC'):
     src += Glob('TC_*.c')
 
 group = DefineGroup('utc_UTest', src, depend = [''])

+ 1 - 1
documentation/6.components/utest/utest.md

@@ -314,7 +314,7 @@ For each module, you can maintain unit testcases in a unified manner in the foll
 
   - `Kconfig` file, which defining configuration options for the unit test cases of this module, the recommended option is named `RT_UTEST_TC_USING_XXXX`, XXXX is the global unique module name of this module.
 
-  - `SConscript` file, note that when adding src files, in addition to relying on `RT_UTEST_TC_USING_XXXX`, you must also rely on `RT_UTEST_USING_ALL_CASES`, the two dependencies are in an "or" relationship. The role of `RT_UTEST_USING_ALL_CASES` is that once this option is turned on, all unit-testcases will be enabled to avoid selecting one by one.
+  - `SConscript` file, when adding src files, you need to rely on `RT_UTEST_TC_USING_XXXX`.
     
 After completing the above steps, rsource the path of the Kconfig file of utest of this module to the file `Kconfig.utestcases`.
 

+ 1 - 1
examples/utest/testcases/cpp11/SConscript

@@ -5,7 +5,7 @@ cwd     = GetCurrentDir()
 src     = []
 CPPPATH = [cwd]
 
-if GetDepend('RT_UTEST_USING_ALL_CASES') or GetDepend('UTEST_CPP11_THREAD_TC'):
+if GetDepend('UTEST_CPP11_THREAD_TC'):
     src += Glob('tc_*.cpp')
 
 group = DefineGroup('utestcases', src, depend = ['RT_USING_UTESTCASES', 'RT_USING_CPLUSPLUS'], CPPPATH = CPPPATH)

+ 0 - 1
src/Kconfig

@@ -242,7 +242,6 @@ config RT_USING_CI_ACTION
     bool "Enable CI Action build mode"
     select RT_USING_UTEST
     select RT_UTEST_USING_AUTO_RUN
-    select RT_UTEST_USING_ALL_CASES
     default n
     help
         Identify that the environment is CI Action.

+ 1 - 1
src/klibc/utest/SConscript

@@ -2,7 +2,7 @@ from building import *
 
 src = []
 
-if GetDepend('RT_UTEST_USING_ALL_CASES') or GetDepend('RT_UTEST_TC_USING_KLIBC'):
+if GetDepend('RT_UTEST_TC_USING_KLIBC'):
     src += Glob('TC_*.c')
 
 group = DefineGroup('utestcases', src, depend = [''])