Browse Source

with recent clang, this triggers -Wunevaluated-expression

specifically, "expression with side effects has no effect in an unevaluated context"
Eli Fidler 9 years ago
parent
commit
5c77c9248c
1 changed files with 8 additions and 4 deletions
  1. 8 4
      test/unittest/valuetest.cpp

+ 8 - 4
test/unittest/valuetest.cpp

@@ -1119,14 +1119,18 @@ TEST(Value, ArrayHelperRangeFor) {
 
     {
         int i = 0;
-        for (auto& v : x.GetArray())
-            EXPECT_EQ(i++, v.GetInt());
+        for (auto& v : x.GetArray()) {
+            EXPECT_EQ(i, v.GetInt());
+            i++;
+        }
         EXPECT_EQ(i, 10);
     }
     {
         int i = 0;
-        for (const auto& v : const_cast<const Value&>(x).GetArray())
-            EXPECT_EQ(i++, v.GetInt());
+        for (const auto& v : const_cast<const Value&>(x).GetArray()) {
+            EXPECT_EQ(i, v.GetInt());
+            i++;
+        }
         EXPECT_EQ(i, 10);
     }